Change in osmo-bts[master]: scheduler: drop meaningless check in trx_sched_set_lchan()

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20696 )

Change subject: scheduler: drop meaningless check in trx_sched_set_lchan()
......................................................................

scheduler: drop meaningless check in trx_sched_set_lchan()

Both TRXC_PDTCH or TRXC_PTCCH are described in 'trx_chan_desc'
(defined as 'const'), and both have TRX_CHAN_FLAG_PDCH set. So
indeed, this condition can never be true.

Change-Id: Ie185a939b48eb859ac1c8ffa0a4f667fda0cb82b
---
M src/common/scheduler.c
1 file changed, 0 insertions(+), 5 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/scheduler.c b/src/common/scheduler.c
index 7f80b02..33de158 100644
--- a/src/common/scheduler.c
+++ b/src/common/scheduler.c
@@ -983,11 +983,6 @@
 	for (i = 0; i < _TRX_CHAN_MAX; i++) {
 		struct l1sched_chan_state *chan_state;
 		chan_state = &l1ts->chan_state[i];
-		/* Skip if pchan type does not match pdch flag.
-		 * FIXME: Is it possible at all? Clarify if so. */
-		if ((trx_sched_multiframes[l1ts->mf_index].pchan == GSM_PCHAN_PDCH)
-		    && !(trx_chan_desc[i].flags & TRX_CHAN_FLAG_PDCH))
-			continue;
 		if (trx_chan_desc[i].chan_nr == (chan_nr & RSL_CHAN_NR_MASK)
 		 && trx_chan_desc[i].link_id == link_id) {
 			rc = 0;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20696
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie185a939b48eb859ac1c8ffa0a4f667fda0cb82b
Gerrit-Change-Number: 20696
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201019/5a99ec61/attachment.htm>