This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20724 ) Change subject: power_control: log diff between 'rx-target' and 'rx-current' ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/20724/2/src/common/power_control.c File src/common/power_control.c: https://gerrit.osmocom.org/c/osmo-bts/+/20724/2/src/common/power_control.c@146 PS2, Line 146: LOGPLCHAN(lchan, DLOOP, LOGL_DEBUG, > wouldn't it be easier to add the single diff figure to the existing log line rather than addign a se […] diff = bts->ul_power_target - avg_ul_rssi_dbm; I see both of those fields being printed in the log line. Agree with laforge, let's not add extra logging for each loop iteration. If you really need it put it in the same log line, otherwise drop it (I vote for dropping). -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20724 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If9188c2b7dd7ad47fb22ef471e8a9a1ba74629f5 Gerrit-Change-Number: 20724 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Mon, 19 Oct 2020 10:06:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201019/3c5b0e19/attachment.htm>