This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20732 ) Change subject: select: Migrate over to poll() ...................................................................... Patch Set 2: -Code-Review (3 comments) https://gerrit.osmocom.org/c/libosmocore/+/20732/2/src/select.c File src/select.c: https://gerrit.osmocom.org/c/libosmocore/+/20732/2/src/select.c@291 PS2, Line 291: OSMO_ASSERT I am also worried about this line. Do we really want to assert() on each iteration? Shouldn't the API responsible for registering new fds ensure that? https://gerrit.osmocom.org/c/libosmocore/+/20732/2/src/select.c@305 PS2, Line 305: p->events |= POLLOUT; > |= POLLERR ? >From `man poll`: POLLERR An error has occurred on the device or stream. This flag is only valid in the revents bitmask; it shall be ignored in the events member. so I think the current approach is correct. https://gerrit.osmocom.org/c/libosmocore/+/20732/2/src/select.c@363 PS2, Line 363: rc = poll(g_poll.poll, n_poll, polling ? 0 : osmo_timers_nearest_ms()); > Please let's keep both implementations around and decide at compile time which to use. […] I agree with Pau here. Also, having the ability to choose the right implementation at compile time would be nice. Especially for embedded targets like osmosom-bb, where it's a good question how well would poll() perform compared to the old good select() in terms of performance. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20732 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9e80da68a144b36926066610d0d3df06abe09bca Gerrit-Change-Number: 20732 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 19 Oct 2020 10:04:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201019/234761b6/attachment.htm>