Change in osmo-bts[master]: power_control: log diff between 'rx-target' and 'rx-current'

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Oct 19 09:43:40 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20724 )

Change subject: power_control: log diff between 'rx-target' and 'rx-current'
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/20724/2/src/common/power_control.c 
File src/common/power_control.c:

https://gerrit.osmocom.org/c/osmo-bts/+/20724/2/src/common/power_control.c@146 
PS2, Line 146: 	LOGPLCHAN(lchan, DLOOP, LOGL_DEBUG,
> I don't see why is this leally needed given that both values are logged immediatelly afterwards in t […]
As far as I can see, what's logged below is the old Uplink power level and the new Uplink power level (if it changes), but not the difference between the expected vs actual signal strength. The signal levels are logged separately, but not the diff. Am I missing something?

In general, I agree that this logging statement might be redundant given that we add another one in the next patch. However, I still find it quite useful for debugging.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20724
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: If9188c2b7dd7ad47fb22ef471e8a9a1ba74629f5
Gerrit-Change-Number: 20724
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Oct 2020 09:43:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201019/f8657120/attachment.htm>


More information about the gerrit-log mailing list