Change in osmo-bts[master]: power_control: do nothing if 'rx-current' equals 'rx-target'

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Oct 19 09:39:07 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20729 )

Change subject: power_control: do nothing if 'rx-current' equals 'rx-target'
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/20729/2/src/common/power_control.c 
File src/common/power_control.c:

https://gerrit.osmocom.org/c/osmo-bts/+/20729/2/src/common/power_control.c@157 
PS2, Line 157: 		return 0;
> Aren't you missing a call to bts_model_adjst_ms_pwr(lchan); here? […]
I am still not sure if we really need this assignment. The point is that on channel activation, the power value that BSC indicated to us (lchan->ms_power_ctrl.current), and the value that MS actually uses and sends in the UL SACCH blocks may not be in sync. Maybe I am wrong here, but how would the BSC know the actual power? This is why I thought it would be good to synchronize the values here .



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20729
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id99c7013a722403e773df8367b1a9d7a856e639b
Gerrit-Change-Number: 20729
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Oct 2020 09:39:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201019/0b4bba90/attachment.htm>


More information about the gerrit-log mailing list