Change in osmo-bts[master]: power_control: tolerate small deviations from 'rx-target'

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Oct 19 09:34:37 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20730 )

Change subject: power_control: tolerate small deviations from 'rx-target'
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/20730/2/src/common/vty.c 
File src/common/vty.c:

https://gerrit.osmocom.org/c/osmo-bts/+/20730/2/src/common/vty.c@261 
PS2, Line 261: 	vty_out(vty, "%s", VTY_NEWLINE);
> Spliting one output line in separate vty_out is IHO confusing, I'd wrap those in 1 line (or 2 vty_ou […]
Not sure why you find it confusing, it's like doing LOGPC("\n"), and we do that in many places.


https://gerrit.osmocom.org/c/osmo-bts/+/20730/2/src/common/vty.c@639 
PS2, Line 639: /* FIXME: libosmovty is unable to handle 'foo <-110-0> [bar <1-25>]' */
> I think you are asking too match to the syntax here, that'd mean crossing over several params.
Well, actually it works, but the help message is not rendered correctly (with '[' and ']', some parts of the text are missing). I wouldn't say it's such a complicated expression. But it was faster to add a separate DEFUN().



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20730
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iacedbd4d69d3d74e2499af5622a07a8af0423da0
Gerrit-Change-Number: 20730
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Oct 2020 09:34:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201019/cf1d5172/attachment.htm>


More information about the gerrit-log mailing list