Change in osmo-ccid-firmware[master]: ccid: fix expected xfer length

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Hoernchen gerrit-no-reply at lists.osmocom.org
Sun Oct 18 21:17:30 UTC 2020


Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/20750 )

Change subject: ccid: fix expected xfer length
......................................................................

ccid: fix expected xfer length

Closes: OS#4818
Change-Id: I41e13625ca7f85b1a14960a938e807bbbebf656a
---
M ccid_common/ccid_slot_fsm.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Hoernchen: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/ccid_common/ccid_slot_fsm.c b/ccid_common/ccid_slot_fsm.c
index 18aa61f..af5b713 100644
--- a/ccid_common/ccid_slot_fsm.c
+++ b/ccid_common/ccid_slot_fsm.c
@@ -298,7 +298,8 @@
 	if (xfb->wLevelParameter != 0x0000)
 		return -8;
 
-	if (msgb_length(msg) != xfb->hdr.dwLength)
+	/* ccid header is 10b */
+	if (msgb_length(msg) != xfb->hdr.dwLength + 10)
 		return -1;
 
 	msgb_pull(msg, 10);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/20750
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I41e13625ca7f85b1a14960a938e807bbbebf656a
Gerrit-Change-Number: 20750
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201018/ef326db8/attachment.htm>


More information about the gerrit-log mailing list