Change in osmo-bts[master]: scheduler: drop meaningless check in trx_sched_set_lchan()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sun Oct 18 10:55:04 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20696 )

Change subject: scheduler: drop meaningless check in trx_sched_set_lchan()
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review+1
> 
> one could maybe have a static assert instead?

I see no point in adding additional checks here. Moreover, I think we can (and should) get rid of TRX_CHAN_FLAG_PDCH, because it's not really needed. Other than this function, it's also used in trx_sched_set_cipher(), where it also makes a little sense, because the BSC would never enable encryption on PDCH slots.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20696
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie185a939b48eb859ac1c8ffa0a4f667fda0cb82b
Gerrit-Change-Number: 20696
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sun, 18 Oct 2020 10:55:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201018/915e5478/attachment.htm>


More information about the gerrit-log mailing list