Change in libosmocore[master]: ns2: More verbose comments on gprs_ns2_vc_mode

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Oct 18 10:37:51 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20703 )

Change subject: ns2: More verbose comments on gprs_ns2_vc_mode
......................................................................

ns2: More verbose comments on gprs_ns2_vc_mode

Change-Id: I647b9d883c1acc47cd352196a819a9c9bf8dc6ff
---
M include/osmocom/gprs/gprs_ns2.h
1 file changed, 7 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/include/osmocom/gprs/gprs_ns2.h b/include/osmocom/gprs/gprs_ns2.h
index 497265e..fddc896 100644
--- a/include/osmocom/gprs/gprs_ns2.h
+++ b/include/osmocom/gprs/gprs_ns2.h
@@ -20,8 +20,13 @@
 struct gprs_ns_ie_ip6_elem;
 
 enum gprs_ns2_vc_mode {
-	NS2_VC_MODE_BLOCKRESET, /* The VC will use RESET/BLOCK/UNBLOCK to start the connection and do ALIVE/ACK */
-	NS2_VC_MODE_ALIVE, /* The will only use ALIVE/ACK */
+	/*! The VC will use RESET/BLOCK/UNBLOCK to start the connection and do ALIVE/ACK.
+	 * This is what is needed for Frame Relay transport, and if you use a R97/R99 Gb
+	 * interface over an IP transport (never standardized by 3GPP) */
+	NS2_VC_MODE_BLOCKRESET,
+	/*! The VC will only use ALIVE/ACK (no RESET/BLOCK/UNBLOCK), which is for Gb-IP
+	 * interface compliant to 3GPP Rel=4 or later. */
+	NS2_VC_MODE_ALIVE,
 };
 
 /*! Osmocom NS primitives according to 48.016 5.2 Service primitves */

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20703
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I647b9d883c1acc47cd352196a819a9c9bf8dc6ff
Gerrit-Change-Number: 20703
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201018/5e666d19/attachment.htm>


More information about the gerrit-log mailing list