Change in osmo-ccid-firmware[master]: HACK: cuart: Artificially extend WTIME by 100ms

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Oct 16 20:39:29 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/19952 )

Change subject: HACK: cuart: Artificially extend WTIME by 100ms
......................................................................

HACK: cuart: Artificially extend WTIME by 100ms

It seems some cards / transactions take longer than we expect, see
https://osmocom.org/issues/4742

With sysmoUSIM-SJS1 a timeout of 12.5ms is sufficient.  But let's better
be tolerant here.

Change-Id: I85a7a0ae6195856fad17f249f0903f144a9aec85
Related: OS#4742
---
M ccid_common/cuart.c
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/ccid_common/cuart.c b/ccid_common/cuart.c
index c617754..ae9738b 100644
--- a/ccid_common/cuart.c
+++ b/ccid_common/cuart.c
@@ -80,6 +80,9 @@
 	/* limit lower wait time to reasonable value */
 	usecs = usecs < 300000 ? 300000 : usecs;
 
+	/* HACK: Some cards seem to take more time than specified? SO#4742 */
+	usecs += 100000;
+
 	if (usecs > 1000000) {
 		secs = usecs / 1000000;
 		usecs = usecs % 1000000;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/19952
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I85a7a0ae6195856fad17f249f0903f144a9aec85
Gerrit-Change-Number: 19952
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201016/9de532f5/attachment.htm>


More information about the gerrit-log mailing list