Change in osmocom-bb[master]: fix trx_if_tx_burst(): do not drop Uplink bursts in TRX_STATE_RSP_WAIT

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Oct 16 17:01:40 UTC 2020


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/20685 )

Change subject: fix trx_if_tx_burst(): do not drop Uplink bursts in TRX_STATE_RSP_WAIT
......................................................................

fix trx_if_tx_burst(): do not drop Uplink bursts in TRX_STATE_RSP_WAIT

Some commands, such as SETTA or SETPOWER, are expected to be sent
when the transceiver is powered on.  We should not drop Uplink
bursts while waiting TRXC response.

For now it's easier to comment out the state check completely,
because the existing TRXC state machine is quite messy.

Change-Id: Iefe6030200b11b29a5790d1f4aa4070ed1d9a493
---
M src/host/trxcon/trx_if.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/host/trxcon/trx_if.c b/src/host/trxcon/trx_if.c
index 7a736a8..e1ce588 100644
--- a/src/host/trxcon/trx_if.c
+++ b/src/host/trxcon/trx_if.c
@@ -641,11 +641,13 @@
 	 * TODO: introduce proper state machines for both
 	 *       transceiver and its TRXC interface.
 	 */
+#if 0
 	if (trx->fsm->state != TRX_STATE_ACTIVE) {
 		LOGP(DTRXD, LOGL_ERROR, "Ignoring TX data, "
 			"transceiver isn't ready\n");
 		return -EAGAIN;
 	}
+#endif
 
 	LOGP(DTRXD, LOGL_DEBUG, "TX burst tn=%u fn=%u pwr=%u\n", tn, fn, pwr);
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/20685
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Iefe6030200b11b29a5790d1f4aa4070ed1d9a493
Gerrit-Change-Number: 20685
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201016/ec598694/attachment.htm>


More information about the gerrit-log mailing list