Change in osmo-bts[master]: fix pcu_if_signal_cb(): do not send INFO.ind if PCU is not connected

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Oct 16 14:55:29 UTC 2020


fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20675 )

Change subject: fix pcu_if_signal_cb(): do not send INFO.ind if PCU is not connected
......................................................................

fix pcu_if_signal_cb(): do not send INFO.ind if PCU is not connected

Sending INFO.ind unconditionally in pcu_if_signal_cb() provokes
a lot of warnings during OML bootstrapping / termination:

  DPCU INFO pcu_sock.c:247 Sending info
  DPCU INFO pcu_sock.c:262 BTS is up
  DPCU INFO pcu_sock.c:205 (bts=0,trx=0) unavailable for PCU (op=Disabled adm=Unlocked)
  DPCU INFO pcu_sock.c:205 (bts=0,trx=1) unavailable for PCU (op=Disabled adm=Unlocked)

Do not call pcu_tx_info_ind() if the PCU is not connected.

Change-Id: If8bc8bec5ad808be8d40e91278a4a4fde84920b0
---
M src/common/pcu_sock.c
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index 550dd37..6586af8 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -407,6 +407,10 @@
 		return -EINVAL;
 	}
 
+	/* Do not send INFO.ind if PCU is not connected */
+	if (!pcu_connected())
+		return 0;
+
 	/* If all infos have been received, of if one info is updated after
 	 * all infos have been received, transmit info update. */
 	if (avail_lai && avail_nse && avail_cell && avail_nsvc[0])

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20675
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: If8bc8bec5ad808be8d40e91278a4a4fde84920b0
Gerrit-Change-Number: 20675
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201016/bc54d312/attachment.htm>


More information about the gerrit-log mailing list