This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20633 ) Change subject: LCS: Lb startup: no need to re-use existing SCCP user ...................................................................... LCS: Lb startup: no need to re-use existing SCCP user This bit of code was borrowed from MSC handling, where multiple MSC might tap on the same SCCP user. There is only one remote SMLC, so there is no need to osmo_sccp_user_find(), just bind it and be done. Change-Id: Ia05c27c13dfb9df4f89c87b8477eea4e62fbe349 --- M src/osmo-bsc/lb.c 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/osmo-bsc/lb.c b/src/osmo-bsc/lb.c index f27a813..654f261 100644 --- a/src/osmo-bsc/lb.c +++ b/src/osmo-bsc/lb.c @@ -465,12 +465,7 @@ LOGP(DLCS, LOGL_NOTICE, "Lb: %s %s: remote (SMLC) SCCP address: %s\n", inst_name, smlc_name, osmo_sccp_inst_addr_name(sccp, &bsc_gsmnet->smlc->smlc_addr)); - /* Bind SCCP user. */ - bsc_gsmnet->smlc->sccp_user = osmo_sccp_user_find(sccp, bsc_gsmnet->smlc->bsc_addr.ssn, bsc_gsmnet->smlc->bsc_addr.pc); - LOGP(DLCS, LOGL_NOTICE, "%s %s: %s\n", inst_name, smlc_name, - bsc_gsmnet->smlc->sccp_user ? "user already bound for this SCCP instance" : "binding SCCP user"); - if (!bsc_gsmnet->smlc->sccp_user) - bsc_gsmnet->smlc->sccp_user = osmo_sccp_user_bind(sccp, smlc_name, sccp_sap_up, bsc_gsmnet->smlc->bsc_addr.ssn); + bsc_gsmnet->smlc->sccp_user = osmo_sccp_user_bind(sccp, smlc_name, sccp_sap_up, bsc_gsmnet->smlc->bsc_addr.ssn); if (!bsc_gsmnet->smlc->sccp_user) return -EINVAL; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20633 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia05c27c13dfb9df4f89c87b8477eea4e62fbe349 Gerrit-Change-Number: 20633 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201015/c331b0a5/attachment.htm>