Change in osmo-bsc[master]: BSSMAP RESET: generalize a_reset FSM

[neels]

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20625 )

Change subject: BSSMAP RESET: generalize a_reset FSM
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/20625/1/include/osmocom/bsc/reset.h 
File include/osmocom/bsc/reset.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/20625/1/include/osmocom/bsc/reset.h@20 
PS1, Line 20: struct reset {
> Ack
i also have 'struct handover' for handover_fsm, 'struct gsm_lchan' for lchan_fsm, 'struct msc_a' for msc_a_fsm, and so on and so on. you didn't ask for _ctx there, and it is no better match here.


https://gerrit.osmocom.org/c/osmo-bsc/+/20625/1/include/osmocom/bsc/reset.h@23 
PS1, Line 23: 	int conn_cfm_failures;
> i guess it's a failure counter, i.e. state and not something you configure.
in particular, the cfg.conn_cfm_failure_threshold sets the max tolerable counter value, while this int is the individual counter per running reset_fsm


https://gerrit.osmocom.org/c/osmo-bsc/+/20625/1/src/osmo-bsc/a_reset.c 
File src/osmo-bsc/a_reset.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/20625/1/src/osmo-bsc/a_reset.c@38 
PS1, Line 38: 	LOGP(DMSC, LOGL_NOTICE, "(msc%d) BSSMAP assocation is up\n", msc->nr);
> %u? or is it an int?
see struct bsc_msc_data and a lot of other code doing "(msc%d)", in fact you guys requested exactly this format a few days ago :)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20625
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib3c3a163186c40a93be0dea666230431172136df
Gerrit-Change-Number: 20625
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 15 Oct 2020 01:19:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201015/6698d11b/attachment.htm>