Change in osmo-ttcn3-hacks[master]: Send NS_ALIVE only after NS-RESET

[daniel]

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20636 )


Change subject: Send NS_ALIVE only after NS-RESET
......................................................................

Send NS_ALIVE only after NS-RESET

We should wait for an NS-RESET before we start sending NS-ALIVE. Also
unified the log messages a bit (received -> Rx).

Related: SYS#5002
Change-Id: Ie01fee70297255b3d9c091bc2cec75b0f915c588
---
M library/NS_Emulation.ttcnpp
1 file changed, 5 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/20636/1

diff --git a/library/NS_Emulation.ttcnpp b/library/NS_Emulation.ttcnpp
index 5fb2aa6..f984aa7 100644
--- a/library/NS_Emulation.ttcnpp
+++ b/library/NS_Emulation.ttcnpp
@@ -218,9 +218,7 @@
 		}
 
 		[config.role_sgsn] NSCP.receive(NS_Provider_Evt:{link_status:=NS_PROV_LINK_STATUS_UP}) {
-			log("Provider Link came up: sending NS-ALIVE");
-			f_sendAlive();
-			Tns_test.start;
+			log("Provider Link came up: waiting for NS-RESET");
 			}
 
 		[not config.role_sgsn] NSCP.receive(NS_Provider_Evt:{link_status:=NS_PROV_LINK_STATUS_UP}) {
@@ -230,7 +228,7 @@
 
 		/* Stop t_alive when receiving ALIVE-ACK */
 		[Tns_alive.running] NSCP.receive(t_NS_ALIVE_ACK) {
-			log("NS-ALIVE-ACK received: stopping Tns-alive; starting Tns-test");
+			log("Rx NS-ALIVE-ACK: stopping Tns-alive; starting Tns-test");
 			Tns_alive.stop;
 			Tns_test.start;
 		}
@@ -250,6 +248,9 @@
 		[] NSCP.receive(tr_NS_RESET(?, config.nsvci, config.nsei)) -> value rf {
 			f_change_state(NSE_S_ALIVE_BLOCKED);
 			NSCP.send(ts_NS_RESET_ACK(config.nsvci, config.nsei));
+			log("Rx NS-RESET: Sending NS-ALIVE");
+			f_sendAlive();
+			Tns_test.start;
 		}
 
 		/* Respond to RESET with wrong NSEI/NSVCI */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20636
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie01fee70297255b3d9c091bc2cec75b0f915c588
Gerrit-Change-Number: 20636
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201013/85eb075a/attachment.htm>