Change in osmo-gsm-tester[master]: {enb, epc, ms}_srs: refactor start/stop and KPI helpers

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20601 )

Change subject: {enb,epc,ms}_srs: refactor start/stop and KPI helpers
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20601/1/src/osmo_gsm_tester/obj/enb_srs.py 
File src/osmo_gsm_tester/obj/enb_srs.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20601/1/src/osmo_gsm_tester/obj/enb_srs.py@77 
PS1, Line 77:         self.kpis = None
I don't see this being used in this class, it should go into the parent class right?


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20601/1/src/osmo_gsm_tester/obj/epc_srs.py 
File src/osmo_gsm_tester/obj/epc_srs.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20601/1/src/osmo_gsm_tester/obj/epc_srs.py@60 
PS1, Line 60:         self.kpis = None
I don't see this being used in this class, it should go into the parent class right?


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20601/1/src/osmo_gsm_tester/obj/ms_srs.py 
File src/osmo_gsm_tester/obj/ms_srs.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20601/1/src/osmo_gsm_tester/obj/ms_srs.py@97 
PS1, Line 97:         self.kpis = None
I don't see this being used in this class, it should go into the parent class right?


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20601/1/src/osmo_gsm_tester/obj/srslte_common.py 
File src/osmo_gsm_tester/obj/srslte_common.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20601/1/src/osmo_gsm_tester/obj/srslte_common.py@30 
PS1, Line 30:     self.kpis = None
Yes it's in the base class, please drop the others.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/20601
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I2ff36df6f1a07ed8ddac39d296d62fe44a215283
Gerrit-Change-Number: 20601
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Oct 2020 10:11:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201013/66c3f19a/attachment.htm>