Change in osmo-bsc[master]: BSSMAP RESET: generalize a_reset FSM

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20625 )

Change subject: BSSMAP RESET: generalize a_reset FSM
......................................................................


Patch Set 1: Code-Review+1

(4 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/20625/1/include/osmocom/bsc/osmo_bsc_sigtran.h 
File include/osmocom/bsc/osmo_bsc_sigtran.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/20625/1/include/osmocom/bsc/osmo_bsc_sigtran.h@43 
PS1, Line 43: void osmo_bsc_sigtran_tx_reset(const struct bsc_msc_data *msc);
Add one line documentation here, specially since there's osmo_bsc_sigtran_reset vs osmo_bsc_sigtran_tx_reset in here.


https://gerrit.osmocom.org/c/osmo-bsc/+/20625/1/include/osmocom/bsc/reset.h 
File include/osmocom/bsc/reset.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/20625/1/include/osmocom/bsc/reset.h@20 
PS1, Line 20: struct reset {
reset_ctx (as before) looks less weird than using simply "reset" here.


https://gerrit.osmocom.org/c/osmo-bsc/+/20625/1/include/osmocom/bsc/reset.h@23 
PS1, Line 23: 	int conn_cfm_failures;
why is this one out of reset_cfg?


https://gerrit.osmocom.org/c/osmo-bsc/+/20625/1/src/osmo-bsc/a_reset.c 
File src/osmo-bsc/a_reset.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/20625/1/src/osmo-bsc/a_reset.c@38 
PS1, Line 38: 	LOGP(DMSC, LOGL_NOTICE, "(msc%d) BSSMAP assocation is up\n", msc->nr);
%u? or is it an int?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20625
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib3c3a163186c40a93be0dea666230431172136df
Gerrit-Change-Number: 20625
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Oct 2020 09:42:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201013/c4717761/attachment.htm>