This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20575 ) Change subject: vty: Set TCP_NODELAY on VTY sockets ...................................................................... Patch Set 1: > That brings us back to the discussion on what is more important regarding logging: delaying logging to safe some resources or to receive the logging content as soon as possible. > I get your point too regarding logging. We could enable/disable NODELAY dynamically based on whether logging is enabled or not, that would be an option. I'm not sure I'm following you. If you are logging to the VTY, then this means it's an interactive user logged in via telnet. The latency of NAGLE certainly won't matter, as the user will never notice the delay caused by nagle. At least not unless you have a *very* high RTT (VSAT?) VTY connection, as the NAGLE delay should typically be a maximum of 1RTT. If your concern is that log output would not be written in case ofa crash: I doubt NAGLE has any influence on that either. You have made the write() syscall on the socket "synchronously", and TCP will have to deliver that to the peer? Or does a close() on the socket mean you loose unackonwledged data that still is in the buffer? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I34f8d3ac70045e48613f67e3c79c2ff49c4d2794 Gerrit-Change-Number: 20575 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Mon, 12 Oct 2020 16:03:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201012/4044b7fc/attachment.htm>