This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/20572 ) Change subject: GTP: Replace recently introduced imsi_str2gtp() ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-ggsn/+/20572/2/gtp/gtp.h File gtp/gtp.h: https://gerrit.osmocom.org/c/osmo-ggsn/+/20572/2/gtp/gtp.h@444 PS2, Line 444: extern const uint64_t gtp_imsi_str2gtp(const char *str); const uint64_t is not needed, and you gain nothing by setting it to const since the value is copied when returned. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/20572 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I910d5339a823332277ce7b5854d5c943ed69ea81 Gerrit-Change-Number: 20572 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith at rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 12 Oct 2020 13:38:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201012/88952245/attachment.htm>