Change in osmo-ttcn3-hacks[master]: bts: Increase SI sampling duration if SI2quater is involved

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Oct 12 13:15:54 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20550 )

Change subject: bts: Increase SI sampling duration if SI2quater is involved
......................................................................

bts: Increase SI sampling duration if SI2quater is involved

The existing sampling duration of 8s was insufficient to collect
sufficient samples to confirm the scheduling rules.

Change-Id: I2f631935c86fb840cdd733c28b2df503512341fa
---
M bts/BTS_Tests.ttcn
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Vadim Yanitskiy: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 1d2a148..0ce611a 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -3994,13 +3994,13 @@
 
 /* helper function: Set given SI via RSL + validate scheduling.
  * CALLER MUST MAKE SURE TO CHANGE GLOBAL si_cfg! */
-private function f_TC_si_sched() runs on test_CT {
+private function f_TC_si_sched(float duration := 8.0) runs on test_CT {
 	var SystemInformationVectorPerTc si_per_tc;
 	f_init_l1ctl();
 	f_l1_tune(L1CTL);
 
 	/* Sample + Validate Scheduling */
-	si_per_tc := f_l1_sample_si(L1CTL);
+	si_per_tc := f_l1_sample_si(L1CTL, duration);
 	f_validate_si_scheduling(si_cfg, si_per_tc);
 
 	setverdict(pass);
@@ -4051,7 +4051,7 @@
 	f_init();
 	si_cfg.si2quater_present := true;
 	f_rsl_bcch_fill_raw(RSL_SYSTEM_INFO_2quater, '050607a8a0364aa698d72ff424feee0506d5e7fff02043'O);
-	f_TC_si_sched();
+	f_TC_si_sched(16.0);
 	Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
 }
 
@@ -4073,7 +4073,7 @@
 	f_rsl_bcch_fill_raw(RSL_SYSTEM_INFO_2quater, '050607a8a0364aa698d72ff424feee0506d5e7fff02043'O);
 	si_cfg.si13_present := true;
 	f_rsl_bcch_fill_raw(RSL_SYSTEM_INFO_13, '0106009000185a6fc9e08410ab2b2b2b2b2b2b2b2b2b2b'O);
-	f_TC_si_sched();
+	f_TC_si_sched(16.0);
 	Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20550
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2f631935c86fb840cdd733c28b2df503512341fa
Gerrit-Change-Number: 20550
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201012/645aa047/attachment.htm>


More information about the gerrit-log mailing list