Change in osmo-ggsn[master]: Fix vty PDP lookups by IMSI

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/20532 )

Change subject: Fix vty PDP lookups by IMSI
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ggsn/+/20532/10/ggsn/ggsn_vty.c 
File ggsn/ggsn_vty.c:

https://gerrit.osmocom.org/c/osmo-ggsn/+/20532/10/ggsn/ggsn_vty.c@897 
PS10, Line 897: if (strlen(argv[1]) != 15) {
              : 		vty_out(vty, "%% Invalid IMSI '%s'%s", argv[1], VTY_NEWLINE);
              : 		return CMD_WARNING;
              : 	}
I don't think there is a strict requirement that IMSIs must always be 15 digits long.  3GPP TS 23.002 states the imsi has "not more than 15 digits" and that the first 5..6 digits are for MCC/MNC matching.  But the remainder (NMSI) can be as short as one wants.

So I think if you wnat to check on the length, it should be a check of "at least 6 digits (3-digit MCC + 2-digit MNC + 1 digit NMSI)" and "not more than 15 digits"



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/20532
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: Icd2e2bc6068c06fbf5d5fe905ebcda8954f33f04
Gerrit-Change-Number: 20532
Gerrit-PatchSet: 10
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 12 Oct 2020 10:59:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201012/eac1a8ed/attachment.htm>