Change in libosmocore[master]: gprs_ns2: add gprs_ns2_nse_foreach_nsvc()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Mon Oct 12 10:24:26 UTC 2020


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20562 )

Change subject: gprs_ns2: add gprs_ns2_nse_foreach_nsvc()
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/20562/1/src/gb/gprs_ns2.c 
File src/gb/gprs_ns2.c:

https://gerrit.osmocom.org/c/libosmocore/+/20562/1/src/gb/gprs_ns2.c@872 
PS1, Line 872: int gprs_ns2_nse_foreach_nsvc(struct gprs_ns2_nse *nse, gprs_ns2_foreach_nsvc_cb cb, void *cb_data)
> Did you think about simply returning the list head and let the user handle it instead?
nsvc is an opaque pointer so the user can't use llist_for_each_entry_*



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20562
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I5a2bb95d05d06d909347e2fb084a446ead888cb3
Gerrit-Change-Number: 20562
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 12 Oct 2020 10:24:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201012/2d3b7998/attachment.htm>


More information about the gerrit-log mailing list