Change in osmo-ggsn[master]: Fix vty PDP lookups by IMSI

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Oct 12 10:19:09 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/20532 )

Change subject: Fix vty PDP lookups by IMSI
......................................................................


Patch Set 8:

(3 comments)

https://gerrit.osmocom.org/c/osmo-ggsn/+/20532/8/ggsn/ggsn_vty.c 
File ggsn/ggsn_vty.c:

https://gerrit.osmocom.org/c/osmo-ggsn/+/20532/8/ggsn/ggsn_vty.c@902 
PS8, Line 902: 	/*  The hash index used below for context lookup
I think all this is clear when reading the new code. Better use this description as an API documentation for imsi_str2gtp


https://gerrit.osmocom.org/c/osmo-ggsn/+/20532/8/gtp/gtp.c 
File gtp/gtp.c:

https://gerrit.osmocom.org/c/osmo-ggsn/+/20532/8/gtp/gtp.c@3497 
PS8, Line 3497:    with gtp encoding */
I think adding the (TS 29.060) thing here makes more sense.


https://gerrit.osmocom.org/c/osmo-ggsn/+/20532/8/gtp/gtp.c@3503 
PS8, Line 3503: 	for (i = 0; i < strlen(imsi); i++)
Move strlen above the loop to do it only once (yeah, good compiler should optimize it, but better make sure.)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/20532
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: Icd2e2bc6068c06fbf5d5fe905ebcda8954f33f04
Gerrit-Change-Number: 20532
Gerrit-PatchSet: 8
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 12 Oct 2020 10:19:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201012/76621227/attachment.htm>


More information about the gerrit-log mailing list