This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
keith gerrit-no-reply at lists.osmocom.orgkeith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/20532 ) Change subject: Fix vty PDP lookups by IMSI ...................................................................... Patch Set 6: (2 comments) https://gerrit.osmocom.org/c/osmo-ggsn/+/20532/4/ggsn/ggsn_vty.c File ggsn/ggsn_vty.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/20532/4/ggsn/ggsn_vty.c@918 PS4, Line 918: imsi |= ((uint64_t) (argv[1][0] - 48)); > This could have been done in a loop, but not really critical. Yeah, didn't want to show off my lack of skills by doing something clunky for the +4 increment. There's probably a fancy nice way. :) https://gerrit.osmocom.org/c/osmo-ggsn/+/20532/4/ggsn/ggsn_vty.c@937 PS4, Line 937: 0 > ... […] Should we? The called function explicitly returns 0 on finding the pdp context, so this way is clear to me. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/20532 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Icd2e2bc6068c06fbf5d5fe905ebcda8954f33f04 Gerrit-Change-Number: 20532 Gerrit-PatchSet: 6 Gerrit-Owner: keith <keith at rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith at rhizomatica.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: Vadim Yanitskiy <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Sun, 11 Oct 2020 08:46:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vadim Yanitskiy <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201011/464ec3f9/attachment.htm>