Change in osmo-pcu[master]: gprs_bssgp_pcu: fix possible memleak in gprs_nsvc_create_and_connect()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Oct 10 10:27:20 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20515 )

Change subject: gprs_bssgp_pcu: fix possible memleak in gprs_nsvc_create_and_connect()
......................................................................

gprs_bssgp_pcu: fix possible memleak in gprs_nsvc_create_and_connect()

Change-Id: I9f44cd22b1353ded6eeb2fe9f8dd4818de758003
---
M src/gprs_bssgp_pcu.cpp
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve



diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp
index 7a0b63f..143d4dc 100644
--- a/src/gprs_bssgp_pcu.cpp
+++ b/src/gprs_bssgp_pcu.cpp
@@ -943,6 +943,7 @@
 
 	if (!bts->nse) {
 		LOGP(DBSSGP, LOGL_ERROR, "Failed to create NSE\n");
+		gprs_ns2_free_bind(bind);
 		return 1;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20515
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I9f44cd22b1353ded6eeb2fe9f8dd4818de758003
Gerrit-Change-Number: 20515
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201010/b15ff73e/attachment.htm>


More information about the gerrit-log mailing list