This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20400 ) Change subject: Introduce NM BTS Site Manager FSM ...................................................................... Patch Set 5: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/20400/5/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/20400/5/src/osmo-bsc/abis_nm.c@832 PS5, Line 832: DEB > Ack I'll fix that in a follow-up patch. https://gerrit.osmocom.org/c/osmo-bsc/+/20400/5/src/osmo-bsc/nm_bts_sm_fsm.c File src/osmo-bsc/nm_bts_sm_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/20400/5/src/osmo-bsc/nm_bts_sm_fsm.c@264 PS5, Line 264: NM_BTS_SM_OP > As I already complained when reviewing the related changes, SM may confuse people as it usually stan […] I don't see much issue here with the naming since Short Messages have nothing to do with this part of the code, so it shouldn't create much confusion, specially given that the struct name is following typical data structure gsm_bts_* prefix. So unless there's really an issue I'm ticking to it. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic001ce6ebeff6f51470ef58140b0235f4a30265e Gerrit-Change-Number: 20400 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: Vadim Yanitskiy <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Fri, 09 Oct 2020 18:11:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge at osmocom.org> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: Vadim Yanitskiy <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201009/7f61e628/attachment.htm>