Change in libosmocore[master]: gprs_ns2_udp: Avoid dangling freed struct in list if binding fails

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Oct 9 12:35:05 UTC 2020


pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20506 )

Change subject: gprs_ns2_udp: Avoid dangling freed struct in list if binding fails
......................................................................

gprs_ns2_udp: Avoid dangling freed struct in list if binding fails

Change-Id: Ic54434b7cfc40136788257e768cae7a2b5d5bc79
---
M src/gb/gprs_ns2_udp.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, approved



diff --git a/src/gb/gprs_ns2_udp.c b/src/gb/gprs_ns2_udp.c
index 3ce0508..207febf 100644
--- a/src/gb/gprs_ns2_udp.c
+++ b/src/gb/gprs_ns2_udp.c
@@ -303,8 +303,6 @@
 	priv->addr = *local;
 	INIT_LLIST_HEAD(&bind->nsvc);
 
-	llist_add(&bind->list, &nsi->binding);
-
 	rc = osmo_sock_init_osa_ofd(&priv->fd, SOCK_DGRAM, IPPROTO_UDP,
 				 local, NULL,
 				 OSMO_SOCK_F_BIND);
@@ -325,6 +323,7 @@
 				dscp, rc, errno);
 	}
 
+	llist_add(&bind->list, &nsi->binding);
 	ns2_vty_bind_apply(bind);
 
 	if (result)

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20506
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic54434b7cfc40136788257e768cae7a2b5d5bc79
Gerrit-Change-Number: 20506
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201009/d52d32e0/attachment.htm>


More information about the gerrit-log mailing list