Change in libosmocore[master]: logging: Change stderr + file target to use non-blocking write

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Oct 8 16:16:06 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20296 )

Change subject: logging: Change stderr + file target to use non-blocking write
......................................................................


Patch Set 9:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/20296/4/src/logging.c 
File src/logging.c:

https://gerrit.osmocom.org/c/libosmocore/+/20296/4/src/logging.c@926 
PS4, Line 926: 	if (rc != msgb_length(msg))
> Well that's maybe the issue here. […]
There's a trade-off here.  If we write too many msgb's within one select cycle, we might be starving other I/O as we implicitly set a higher priority to LOG output (write multiple msgb per cycle) over protocol I/O (write one msgb per cycle for RSL, SCCP, ...).

Sure, we could have an upper bound (like 10?). Let's leave that for a follow-up patch.


https://gerrit.osmocom.org/c/libosmocore/+/20296/4/src/select.c 
File src/select.c:

https://gerrit.osmocom.org/c/libosmocore/+/20296/4/src/select.c@283 
PS4, Line 283: 	log_target_file_switch_to_wqueue(osmo_stderr_target);
> There's a use case: debugging. […]
This has been adressed in the latest revision, see the changelog.  There's now no automatic unconditional switch to non-blocking from osmo_select_main() anymore.  Rather, it depends on VTY and API usage.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20296
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia58fd78535c41b3da3aeb7733aadc785ace610da
Gerrit-Change-Number: 20296
Gerrit-PatchSet: 9
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 08 Oct 2020 16:16:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201008/da77baf9/attachment.htm>


More information about the gerrit-log mailing list