Change in osmo-bsc[master]: gsm_08_08: cosmetic: avoid confusion between LINKID and DLCI

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Oct 8 07:12:28 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20414 )

Change subject: gsm_08_08: cosmetic: avoid confusion between LINKID and DLCI
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/20414/1/include/osmocom/bsc/gsm_data.h 
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/20414/1/include/osmocom/bsc/gsm_data.h@54 
PS1, Line 54:  
> JFYI: I am not the author of this code, and not trying to advocate the current approach. […]
a message can start as a RSL message and then be transformed during processing into a BSSAP message (or vice versa).  That should be the normal course of action for MM/CC messages, for example.

If we do have unused parts of msgb->cb in this context, I think it would be best to use separate parts/members, yes.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20414
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I41e34670a4e173cdbd9617d2c7f7c49b1f5ab46c
Gerrit-Change-Number: 20414
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 08 Oct 2020 07:12:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201008/924cc27e/attachment.htm>


More information about the gerrit-log mailing list