Change in osmo-mgw[master]: mgcp_vty: add user attributes to configuration commands

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Wed Oct 7 10:33:15 UTC 2020


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/20250 )

Change subject: mgcp_vty: add user attributes to configuration commands
......................................................................


Patch Set 6: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-mgw/+/20250/6/src/libosmo-mgcp/mgcp_vty.c 
File src/libosmo-mgcp/mgcp_vty.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/20250/6/src/libosmo-mgcp/mgcp_vty.c@406 
PS6, Line 406: CMD_ATTR_IMMEDIATE
It's not a configuration command, but a navigation command. We should not add any attributes to them.


https://gerrit.osmocom.org/c/osmo-mgw/+/20250/6/src/libosmo-mgcp/mgcp_vty.c@930 
PS6, Line 930: CMD_ATTR_IMMEDIATE
Here I agree, because this command may allocate a new trunk.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/20250
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I2d9487801b3b78f94577264b56d217c926ef76a9
Gerrit-Change-Number: 20250
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 07 Oct 2020 10:33:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201007/4ec2fd35/attachment.htm>


More information about the gerrit-log mailing list