Change in osmo-sgsn[master]: sgsn: Use the new NS2 api

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Oct 5 14:32:07 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/20397 )

Change subject: sgsn: Use the new NS2 api
......................................................................


Patch Set 4:

(4 comments)

https://gerrit.osmocom.org/c/osmo-sgsn/+/20397/4//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-sgsn/+/20397/4//COMMIT_MSG@7 
PS4, Line 7: sgsn: Use the new NS2 api
it would be good to elaborate a bit here.  Waht does this entail?  Does it have implications on config file compatibility?

Also, I guess we should "Depends: libosmocore.git <commit-hash>".


https://gerrit.osmocom.org/c/osmo-sgsn/+/20397/4/src/sgsn/gprs_gb.c 
File src/sgsn/gprs_gb.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/20397/4/src/sgsn/gprs_gb.c@126 
PS4, Line 126: NS-NSE
isn't that just a NS-E ?


https://gerrit.osmocom.org/c/osmo-sgsn/+/20397/4/src/sgsn/gprs_gb.c@141 
PS4, Line 141: DGPRS
these are DPGRS and below are DPCU. is that intentional?


https://gerrit.osmocom.org/c/osmo-sgsn/+/20397/4/src/sgsn/gprs_gb.c@161 
PS4, Line 161: DPCU
here DPCU, DGPRS above.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/20397
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I92a3bcaf166b091a22d74c7c1586964d33d7cc9d
Gerrit-Change-Number: 20397
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 05 Oct 2020 14:32:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201005/feb395a9/attachment.htm>


More information about the gerrit-log mailing list