Change in osmo-bsc[master]: oml: encode IPv6 NSVC using the new OML attribute NM_ATT_OSMO_NS_LINK...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Sat Oct 3 18:23:29 UTC 2020


lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20234 )

Change subject: oml: encode IPv6 NSVC using the new OML attribute NM_ATT_OSMO_NS_LINK_CFG
......................................................................


Patch Set 11:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/20234/10/src/osmo-bsc/pcu_sock.c 
File src/osmo-bsc/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/20234/10/src/osmo-bsc/pcu_sock.c@195 
PS10, Line 195: 		if (nsvc->remote.u.sa.sa_family != AF_INET6) {
> I don't get all this... […]
it has to be == AF_INET6. sorry.

But what's the problem with the hole? So the info_ind contains zeroes on the first nsvc. But that's not a problem.


https://gerrit.osmocom.org/c/osmo-bsc/+/20234/10/tests/nanobts_omlattr/nanobts_omlattr_test.c 
File tests/nanobts_omlattr/nanobts_omlattr_test.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/20234/10/tests/nanobts_omlattr/nanobts_omlattr_test.c@30 
PS10, Line 30: #include <osmocom/core/sockaddr_str.h>
> why is this include added here? is this needed? then it goes into another commit, it's not related.
It's needed because I've started using it here.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20234
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I6529876a3c1116a79dd624312243d8ae48a41fe2
Gerrit-Change-Number: 20234
Gerrit-PatchSet: 11
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 03 Oct 2020 18:23:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201003/d5c39687/attachment.htm>


More information about the gerrit-log mailing list