This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20387 ) Change subject: ns2: parse the return code of gprs_ns2_ip_bind ...................................................................... ns2: parse the return code of gprs_ns2_ip_bind Fixes a crash when the bind fails. Change-Id: I96c8e871a350f8f7b9ba2450bb37b90b535f42e2 --- M src/gb/gprs_ns2_vty.c 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/gb/gprs_ns2_vty.c b/src/gb/gprs_ns2_vty.c index 9deb3a1..d274cbe 100644 --- a/src/gb/gprs_ns2_vty.c +++ b/src/gb/gprs_ns2_vty.c @@ -758,8 +758,7 @@ } else { /* UDP */ osmo_sockaddr_str_to_sockaddr(&priv.udp, &sockaddr.u.sas); - gprs_ns2_ip_bind(vty_nsi, &sockaddr, priv.dscp, &bind); - if (!bind) { + if (gprs_ns2_ip_bind(vty_nsi, &sockaddr, priv.dscp, &bind)) { /* TODO: could not bind on the specific address */ return -1; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I96c8e871a350f8f7b9ba2450bb37b90b535f42e2 Gerrit-Change-Number: 20387 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201003/009e0dc6/attachment.htm>