Change in osmo-bts[master]: Introduce NM BTS Site Manager FSM

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Oct 2 21:42:12 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/20408 )

Change subject: Introduce NM BTS Site Manager FSM
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/include/osmo-bts/bts.h 
File include/osmo-bts/bts.h:

https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/include/osmo-bts/bts.h@148 
PS1, Line 148: /* NM BTS Site Manager FSM */
             : 		struct osmo_fsm_inst *fi;
             : 		bool opstart_success;
why don't we move this into the gsm_abis_mo?  Shouldn't every one of them have a fsm_inst and some state whether or not it was opstarted successfully?


https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/src/common/bts.c 
File src/common/bts.c:

https://gerrit.osmocom.org/c/osmo-bts/+/20408/1/src/common/bts.c@225 
PS1, Line 225: bts_sm%d
> AFAIR, there can be only one site manager, it's not a per-BTS entity. […]
fixeria is correct.  I made that mistake early on when we started with the BS-11, where there was only one BTS per physical box and hence a 1:1 relationship with the site manager.

for osmo-bts, I currently don't forsee us having multiple logicla BTSs within one process, so it is not super critical.

the biggest problem about this mistake is in osmo-bsc.  Particularly in context of RBS6000 support, it is quite sad that we currently can only support one BTS, while the hardware can do as many logical BTS within 24 TRX as we want.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/20408
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iab2d17c45c9642860cd2d5d523c1baae24502243
Gerrit-Change-Number: 20408
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 02 Oct 2020 21:42:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201002/20763216/attachment.htm>


More information about the gerrit-log mailing list