This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20234 )
Change subject: oml: encode IPv6 NSVC using the new OML attribute NM_ATT_OSMO_NS_LINK_CFG
......................................................................
Patch Set 10: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/c/osmo-bsc/+/20234/10/src/osmo-bsc/pcu_sock.c
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/20234/10/src/osmo-bsc/pcu_sock.c@195
PS10, Line 195: if (nsvc->remote.u.sa.sa_family != AF_INET6) {
I don't get all this... so you are first dropping AF_INET and AF_UNSPEC, and later AF_INET6 and AF_UNSPEC, so nothing will end up being stored in info_ind....
And there's still a problem with holes in the resulting info_ind afaict.
https://gerrit.osmocom.org/c/osmo-bsc/+/20234/10/tests/nanobts_omlattr/nanobts_omlattr_test.c
File tests/nanobts_omlattr/nanobts_omlattr_test.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/20234/10/tests/nanobts_omlattr/nanobts_omlattr_test.c@30
PS10, Line 30: #include <osmocom/core/sockaddr_str.h>
why is this include added here? is this needed? then it goes into another commit, it's not related.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20234
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I6529876a3c1116a79dd624312243d8ae48a41fe2
Gerrit-Change-Number: 20234
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 02 Oct 2020 18:41:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201002/13af3b24/attachment.htm>