Change in osmo-bsc[master]: vty: add attributes to VTY commands indicating when they apply

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Oct 2 08:45:29 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19670 )

Change subject: vty: add attributes to VTY commands indicating when they apply
......................................................................


Patch Set 8:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/19670/8/src/osmo-bsc/osmo_bsc_main.c 
File src/osmo-bsc/osmo_bsc_main.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/19670/8/src/osmo-bsc/osmo_bsc_main.c@653 
PS8, Line 653: usr_attr_letters
One more thing: as was discussed in the mailing list, let's use lower case letters for application specific flags. Upper case should be used in libosmo-*, so we have a clear distinction.


https://gerrit.osmocom.org/c/osmo-bsc/+/19670/8/src/osmo-bsc/osmo_bsc_main.c@656 
PS8, Line 656: N
I think there can also be 'NEW_BTS', 'NEW_TRX', and so on... Let's rather use 'l' or 'c' (first/second letter of lchan) here?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19670
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I3bf9223295fc4a2fcb4046a1f29f792ff6a41d51
Gerrit-Change-Number: 19670
Gerrit-PatchSet: 8
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Assignee: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 02 Oct 2020 08:45:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201002/3333ecb4/attachment.htm>


More information about the gerrit-log mailing list