Change in osmo-bsc[master]: refactor paging: introduce bsc_paging_params

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Oct 1 22:09:05 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20347 )

Change subject: refactor paging: introduce bsc_paging_params
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/20347/2/include/osmocom/bsc/paging.h 
File include/osmocom/bsc/paging.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/20347/2/include/osmocom/bsc/paging.h@36 
PS2, Line 36: msc%d
How about "(msc%d) Paging: ..."?


https://gerrit.osmocom.org/c/osmo-bsc/+/20347/2/src/osmo-bsc/osmo_bsc_bssap.c 
File src/osmo-bsc/osmo_bsc_bssap.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/20347/2/src/osmo-bsc/osmo_bsc_bssap.c@133 
PS2, Line 133: %u
Unrelated hex -> dec format change.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20347
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I27ca78fc6ff8ef1101554c0a8429e34945ca6f3c
Gerrit-Change-Number: 20347
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Oct 2020 22:09:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201001/c790e36d/attachment.htm>


More information about the gerrit-log mailing list