This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20339 ) Change subject: gscon_bssmap_clear(): guard against NULL msc ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/20339/1/src/osmo-bsc/bsc_subscr_conn_fsm.c File src/osmo-bsc/bsc_subscr_conn_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/20339/1/src/osmo-bsc/bsc_subscr_conn_fsm.c@150 PS1, Line 150: gsm0808_create_clear_rqst AFAIU, this function allocates a msgb on heap. https://gerrit.osmocom.org/c/osmo-bsc/+/20339/1/src/osmo-bsc/bsc_subscr_conn_fsm.c@153 PS1, Line 153: return ... so we have a memleak here? https://gerrit.osmocom.org/c/osmo-bsc/+/20339/1/src/osmo-bsc/bsc_subscr_conn_fsm.c@158 PS1, Line 158: return and here? I would rather move this check upwards, because it does not make sense to allocate msgb if there is no MSC... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I95b16cebb6ff78649f72a09b5d6c7c7e403233fa Gerrit-Change-Number: 20339 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Thu, 01 Oct 2020 21:20:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201001/81ea3134/attachment.htm>