Change in libosmocore[master]: add GAD coding for Location Services

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20332 )

Change subject: add GAD coding for Location Services
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/20332/1/src/gsm/gad.c 
File src/gsm/gad.c:

https://gerrit.osmocom.org/c/libosmocore/+/20332/1/src/gsm/gad.c@37 
PS1, Line 37: 	OSMO_VALUE_STRING(OSMO_GAD_TYPE_ELL_POINT),
> that's the style you guys use, yes. […]
I'm sorry to always "fight" against your instincts here, neels. I am with pespin, though, as to me, consistency almost always overrides all other arguments.  We don't do it in general, traditionally.  So rather than having some parts of the code do A and other parts do B, we stick with "A" unless there is a strong move to migrate everything to "B".


https://gerrit.osmocom.org/c/libosmocore/+/20332/1/src/gsm/gad.c@250 
PS1, Line 250: 	*gad = (struct osmo_gad){};
> No I don't agree, there's no point in memzeroing padding unless the chunk of memory needs to be tran […]
pespin: I think we ha that discussion before, and the language construct neels uses here should be equivalent to a memset, without any room for interpretation.

I would assume that for small amounts of padding between [typical integer sized] fields, there is virtually no overhead, neither in code size nor in execution time.  The CPU works on muhc larger loads/stores anyway, and I would expect the compiler to motsly optimize that away. 

So I don't think we should be discussing this. I think there are arguments both ways, but non of them is strong.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20332
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7a9dd805a91b1ebb6353bde0cd169218acbf223c
Gerrit-Change-Number: 20332
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Oct 2020 18:00:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201001/5ad6b8ae/attachment.htm>