Change in libosmocore[master]: add GAD coding for Location Services

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20332 )

Change subject: add GAD coding for Location Services
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/20332/1/src/gsm/gad.c 
File src/gsm/gad.c:

https://gerrit.osmocom.org/c/libosmocore/+/20332/1/src/gsm/gad.c@250 
PS1, Line 250: 	*gad = (struct osmo_gad){};
> I want the result of the GAD API to be deterministic and that is what I want to also verify in the t […]
No I don't agree, there's no point in memzeroing padding unless the chunk of memory needs to be transferred somewhere else (data leak, eg sening over network), and it's not the case.

And btw, I wouldn't rely on the compiler memzeroing padding using those compiler constructs, it may well simply set all fields to zero but leave padding alone. You should use memset() if you want to make sure.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20332
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7a9dd805a91b1ebb6353bde0cd169218acbf223c
Gerrit-Change-Number: 20332
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Oct 2020 17:41:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201001/4b7bd952/attachment.htm>