Change in osmo-ttcn3-hacks[master]: BSSAP_LE: comment/log tweaks

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Thu Oct 1 14:06:56 UTC 2020


neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20364 )

Change subject: BSSAP_LE: comment/log tweaks
......................................................................

BSSAP_LE: comment/log tweaks

Change-Id: I39ae5abc932c8cb5eb37b8c25a84621bd9ff30ca
---
M library/BSSAP_LE_Emulation.ttcn
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved
  laforge: Looks good to me, approved



diff --git a/library/BSSAP_LE_Emulation.ttcn b/library/BSSAP_LE_Emulation.ttcn
index 0b9fe16..294ac62 100644
--- a/library/BSSAP_LE_Emulation.ttcn
+++ b/library/BSSAP_LE_Emulation.ttcn
@@ -345,7 +345,7 @@
 private altstep as_reset_ack() runs on BSSAP_LE_Emulation_CT {
 	var BSSAP_LE_N_UNITDATA_ind ud_ind;
 	[] BSSAP_LE.receive(tr_BSSAP_LE_UNITDATA_ind(?, ?, tr_BSSMAP_LE_Reset)) -> value ud_ind {
-		log("Respoding to inbound RESET with RESET-ACK");
+		log("Responding to inbound RESET with RESET-ACK");
 		BSSAP_LE.send(ts_BSSAP_LE_UNITDATA_req(ud_ind.callingAddress, ud_ind.calledAddress,
 			   ts_BSSMAP_LE_ResetAck));
 		repeat;
@@ -611,7 +611,7 @@
 		l3_info := conn_ind.userData.pdu.bssmap.completeLayer3Information.layer3Information.layer3info;
 		log("ExpectedCreateCallback completeLayer3Information");
 	} else {
-		setverdict(fail, "N-CONNECT.ind with L3 != COMPLETE L3");
+		setverdict(fail, "N-CONNECT.ind with L3 != { PerformLocReq | COMPLETE L3 }");
 		mtc.stop;
 	}
 
@@ -684,6 +684,7 @@
 }
 
 /* helper function for clients to register their IMSI/TMSI */
+/* FIXME: there is no TMSI in BSSMAP-LE */
 function f_bssap_le_register_imsi(hexstring imsi, template (omit) OCT4 tmsi_or_omit)
 runs on BSSAP_LE_ConnHdlr {
 	var OCT4 tmsi;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20364
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I39ae5abc932c8cb5eb37b8c25a84621bd9ff30ca
Gerrit-Change-Number: 20364
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201001/4dfae35b/attachment.htm>


More information about the gerrit-log mailing list