Change in libosmocore[master]: osmo_use_count_to_str: make robust against unused use_count

[neels]

neels has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20330 )

Change subject: osmo_use_count_to_str: make robust against unused use_count
......................................................................

osmo_use_count_to_str: make robust against unused use_count

A use_count struct gets properly initialized once the first use count is added.
Normally, this happens directly at object allocation. Still make sure
osmo_use_count_to_str_*() don't crash on a yet unused struct use_count.

Change-Id: I47b1acc7f13f2557c78e2cbe67d4690709ce795e
---
M src/use_count.c
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/use_count.c b/src/use_count.c
index 738cc5d..d07e47f 100644
--- a/src/use_count.c
+++ b/src/use_count.c
@@ -127,6 +127,9 @@
 
 	OSMO_STRBUF_PRINTF(sb, "%" PRId32 " (", count);
 
+	if (!uc->use_counts.next)
+		goto uninitialized;
+
 	first = true;
 	llist_for_each_entry(e, &uc->use_counts, entry) {
 		if (!e->count)
@@ -140,6 +143,8 @@
 	}
 	if (first)
 		OSMO_STRBUF_PRINTF(sb, "-");
+
+uninitialized:
 	OSMO_STRBUF_PRINTF(sb, ")");
 	return sb.chars_needed;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20330
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I47b1acc7f13f2557c78e2cbe67d4690709ce795e
Gerrit-Change-Number: 20330
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201001/c46c71e2/attachment.htm>