Change in libosmocore[master]: add BSSLAP coding for Location Services

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20333 )

Change subject: add BSSLAP coding for Location Services
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/libosmocore/+/20333/1/include/osmocom/gsm/bsslap.h 
File include/osmocom/gsm/bsslap.h:

https://gerrit.osmocom.org/c/libosmocore/+/20333/1/include/osmocom/gsm/bsslap.h@71 
PS1, Line 71: 
why spaces in all these structs?


https://gerrit.osmocom.org/c/libosmocore/+/20333/1/src/gsm/bsslap.c 
File src/gsm/bsslap.c:

https://gerrit.osmocom.org/c/libosmocore/+/20333/1/src/gsm/bsslap.c@183 
PS1, Line 183: #define PARSE_ERR(errmsg) \
Not sure what the benefit for this macro is...
And btw you are duplicating ";".


https://gerrit.osmocom.org/c/libosmocore/+/20333/1/src/gsm/bsslap.c@458 
PS1, Line 458: 	{}
IIRC we had problems with this not finished in 0x00 and NULL? maybe some libosmocore linter?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20333
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6409c4bcac402dc7626a3afce9081c59cd715fe8
Gerrit-Change-Number: 20333
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Oct 2020 10:11:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201001/18d6b926/attachment.htm>