Change in libosmocore[master]: add GAD coding for Location Services

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20332 )

Change subject: add GAD coding for Location Services
......................................................................


Patch Set 1:

(5 comments)

https://gerrit.osmocom.org/c/libosmocore/+/20332/1/src/gsm/gad.c 
File src/gsm/gad.c:

https://gerrit.osmocom.org/c/libosmocore/+/20332/1/src/gsm/gad.c@37 
PS1, Line 37: 	OSMO_VALUE_STRING(OSMO_GAD_TYPE_ELL_POINT),
probably want to have this as "ELL_POINT", etc. instead of full enum name


https://gerrit.osmocom.org/c/libosmocore/+/20332/1/src/gsm/gad.c@55 
PS1, Line 55: uint32_t osmo_gad_enc_lat(int32_t lat_deg_1e6)
Missing documentation in all functions. I think it is really needed here.


https://gerrit.osmocom.org/c/libosmocore/+/20332/1/src/gsm/gad.c@162 
PS1, Line 162: #ifdef GAD_FUTURE
explain this?


https://gerrit.osmocom.org/c/libosmocore/+/20332/1/src/gsm/gad.c@250 
PS1, Line 250: 	*gad = (struct osmo_gad){};
what's the point of memzeroing here?


https://gerrit.osmocom.org/c/libosmocore/+/20332/1/src/gsm/gad.c@293 
PS1, Line 293: 		OSMO_STRBUF_PRINTF(sb, "Ellipsoid-point-with-uncertainty-circle{to-str-not-implemented}");
all of these look like they should mostly be calls to get the value from value_string....



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20332
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I7a9dd805a91b1ebb6353bde0cd169218acbf223c
Gerrit-Change-Number: 20332
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Oct 2020 10:06:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201001/83e30fa9/attachment.htm>