Change in osmo-ttcn3-hacks[master]: bsc: undup f_verify_active_layer3()

[neels]

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20360 )


Change subject: bsc: undup f_verify_active_layer3()
......................................................................

bsc: undup f_verify_active_layer3()

Change-Id: Ia4433618787b58f8789c9e97cdfbb8b320a09395
---
M bsc/BSC_Tests.ttcn
1 file changed, 21 insertions(+), 30 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/60/20360/1

diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 3a817f4..9672357 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -4464,6 +4464,25 @@
 	f_shutdown_helper();
 }
 
+private function f_verify_active_layer3() runs on MSC_ConnHdlr
+{
+	/* The old lchan and conn should still be active. See that arbitrary L3
+	 * is still going through. */
+	var octetstring l3 := '0123456789'O;
+	RSL.send(ts_RSL_DATA_IND(g_chan_nr, valueof(ts_RslLinkID_DCCH(0)), l3));
+	var template PDU_BSSAP exp_data := {
+		    discriminator := '1'B,
+		    spare := '0000000'B,
+		    dlci := '00'O,
+		    lengthIndicator := 5,
+		    pdu := {
+			dtap := l3
+		    }
+		};
+	BSSAP.receive(exp_data);
+	setverdict(pass);
+}
+
 /* BSC asks for inter-BSC HO, but the MSC decides that it won't happen and
  * simply never sends a BSSMAP Handover Command. */
 private function f_tc_ho_out_fail_no_msc_response(charstring id) runs on MSC_ConnHdlr {
@@ -4484,21 +4503,7 @@
 	 * Let's give it a bit extra. */
 	f_sleep(15.0);
 
-	/* The old lchan and conn should still be active. See that arbitrary L3
-	 * is still going through. */
-	var octetstring l3 := '0123456789'O;
-	RSL.send(ts_RSL_DATA_IND(g_chan_nr, valueof(ts_RslLinkID_DCCH(0)), l3));
-	var template PDU_BSSAP exp_data := {
-		    discriminator := '1'B,
-		    spare := '0000000'B,
-		    dlci := '00'O,
-		    lengthIndicator := 5,
-		    pdu := {
-			dtap := l3
-		    }
-		};
-	BSSAP.receive(exp_data);
-	setverdict(pass);
+	f_verify_active_layer3();
 	f_sleep(1.0);
 }
 testcase TC_ho_out_fail_no_msc_response() runs on test_CT {
@@ -4576,21 +4581,7 @@
 
 	f_sleep(1.0);
 
-	/* The old lchan and conn should still be active. See that arbitrary L3
-	 * is still going through. */
-	var octetstring l3 := '0123456789'O;
-	RSL.send(ts_RSL_DATA_IND(g_chan_nr, valueof(ts_RslLinkID_DCCH(0)), l3));
-	var template PDU_BSSAP exp_data := {
-		    discriminator := '1'B,
-		    spare := '0000000'B,
-		    dlci := '00'O,
-		    lengthIndicator := 5,
-		    pdu := {
-			dtap := l3
-		    }
-		};
-	BSSAP.receive(exp_data);
-	setverdict(pass);
+	f_verify_active_layer3();
 	f_sleep(1.0);
 
 	setverdict(pass);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20360
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia4433618787b58f8789c9e97cdfbb8b320a09395
Gerrit-Change-Number: 20360
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201001/b0544d90/attachment.htm>