Change in osmo-pcu[master]: Dl TBF: Get rid of LLC UI dummy blocks following other data

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Nov 30 16:14:57 UTC 2020


Hello Jenkins Builder, fixeria, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-pcu/+/21387

to look at the new patch set (#4).

Change subject: Dl TBF: Get rid of LLC UI dummy blocks following other data
......................................................................

Dl TBF: Get rid of LLC UI dummy blocks following other data

According to:
* 3GPP TS 44.060 version 16.0.0 "9.3.1a Delayed release of downlink Temporary Block Flow"
* 3GPP TS 44.064 version 16.0.0 "6.4.2.2 Unconfirmed Information (UI) Dummy command"

LLC UI Dummy frames are to be used when there no more data to send, only
in order to delay the release of a TBF. Hence, while not incorrect per
se, makes no sense to send those LLC UI Dummy frames inserted into
rlcmac blocks which already contain other LLC frames, since the MS in
that case is already being kept active.
It only makes sense to send those LLC UI Dummy frames when we have
nothing else to send, that is, alone inside a RLCMAC block without other
LLC frames.

Related: OS#4849
Change-Id: Ifae1a7b2b3dfad8df19585063088ba0df2749c8f
---
M src/encoding.cpp
M src/encoding.h
M src/tbf_dl.cpp
M tests/tbf/TbfTest.err
4 files changed, 170 insertions(+), 198 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/87/21387/4
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21387
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ifae1a7b2b3dfad8df19585063088ba0df2749c8f
Gerrit-Change-Number: 21387
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201130/f2fadcb8/attachment.htm>


More information about the gerrit-log mailing list