This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21402 ) Change subject: gbproxy: Fix log messages in timeout situations ...................................................................... gbproxy: Fix log messages in timeout situations Printing an unbound 'rx' variable when nothing was received due to timeout is somehow not really useful. Print what we expected to receive. Change-Id: Idab8bed06281468164006682aa6b4c2c3e236880 --- M gbproxy/GBProxy_Tests.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn index b708fa0..2120fa7 100644 --- a/gbproxy/GBProxy_Tests.ttcn +++ b/gbproxy/GBProxy_Tests.ttcn @@ -571,7 +571,7 @@ mtc.stop; } [] T.timeout { - setverdict(fail, "Timeout waiting for BSSGP on SGSN side: ", rx); + setverdict(fail, "Timeout waiting for BSSGP on SGSN side: ", exp_rx); mtc.stop; } } @@ -606,7 +606,7 @@ mtc.stop; } [] T.timeout { - setverdict(fail, "Timeout waiting for BSSGP on PCU side: ", rx); + setverdict(fail, "Timeout waiting for BSSGP on PCU side: ", exp_rx); mtc.stop; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idab8bed06281468164006682aa6b4c2c3e236880 Gerrit-Change-Number: 21402 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201130/3e5b319b/attachment.htm>