This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
ninjab3s gerrit-no-reply at lists.osmocom.orgninjab3s has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302 ) Change subject: Introduce Android UEs as new modems ...................................................................... Patch Set 3: (4 comments) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/3/src/osmo_gsm_tester/obj/android_host.py File src/osmo_gsm_tester/obj/android_host.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/3/src/osmo_gsm_tester/obj/android_host.py@38 PS3, Line 38: ['find', str(self.remote_run_dir), What do you say to this solution? sudo is not necessary anymore and I only remove the files that have the specific extensions. The only other solution here would be, as you have proposed, to delete the complete folder but it would be more overhead in terms of number of commands to be used. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/3/src/osmo_gsm_tester/obj/android_host.py@45 PS3, Line 45: popen_args_clear_diag_logs = \ I could not find any other way to do this that applies to all Android devices we have here to test. The path is hard coded and is non standard, so there shouldn't be anything in there besides the 3 files created by diag_mdlog. Can we leave it like that or should I investigate again to find another way? https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/2/src/osmo_gsm_tester/obj/bitrate_monitor.py File src/osmo_gsm_tester/obj/bitrate_monitor.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/2/src/osmo_gsm_tester/obj/bitrate_monitor.py@58 PS2, Line 58: self.rem_host.remote_user = 'root' > ACK, but then why not simply setting "root" as ssh_user in resources. […] I can't do that because the commands to be executed on the machine running the ADB instance and hosting the Android UEs need the remote_user='jenkins'. The problematic here is that in case of remote execution the slave unit has the same ip as the Android UEs. The only difference is the port of the ssh server. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/2/sysmocom/suites/4g/iperf3_dl.py File sysmocom/suites/4g/iperf3_dl.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302/2/sysmocom/suites/4g/iperf3_dl.py@26 PS2, Line 26: proc = iperf3cli.prepare_test_proc(iperf3cli.DIR_DL, ue.netns(), bitrate=max_rate, ue=ue) > What about extending RunNode with a new "run_type" = "adb" and then add a new schema property "adb_s […] Very good idea! Makes it much cleaner and I don't have to touch the iperf3_dl/ul tests. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I79a5d803e869a868d4dac5e0d4c2feb38038dc5c Gerrit-Change-Number: 21302 Gerrit-PatchSet: 3 Gerrit-Owner: ninjab3s <nils.fuerste at softwareradiosystems.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 30 Nov 2020 14:00:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ninjab3s <nils.fuerste at softwareradiosystems.com> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201130/a24dddbf/attachment.htm>