Change in osmo-bts[master]: l1sap: add repeated uplink SACCH

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Hoernchen gerrit-no-reply at lists.osmocom.org
Mon Nov 30 13:43:50 UTC 2020


Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21185 )

Change subject: l1sap: add repeated uplink SACCH
......................................................................


Patch Set 5:

(1 comment)

> Patch Set 5:
> 
> (8 comments)
> 
> (ensure all comments are sent)

https://gerrit.osmocom.org/c/osmo-bts/+/21185/4/src/osmo-bts-trx/sched_lchan_xcch.c 
File src/osmo-bts-trx/sched_lchan_xcch.c:

https://gerrit.osmocom.org/c/osmo-bts/+/21185/4/src/osmo-bts-trx/sched_lchan_xcch.c@37 
PS4, Line 37: /* Add two arrays of sbits */
            : static void add_sbits(sbit_t *current, const sbit_t *previous)
> I have moved over to the averaged approach. […]
I believe addition is fine, since it could be perceived as a diversity scheme and the individual soft bits are already weighted according to the channel conditions, so it's a mrc approach, just later on the soft bit level.
After all smaller values near 0 are not equally "valuable" as other larger values, but merely a product of a bad channel, so averaging would decrease the confidence level instead of reinforcing it...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21185
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I7e4cc33cc010866e41e3b594351a7f7bf93e08ac
Gerrit-Change-Number: 21185
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 30 Nov 2020 13:43:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201130/812eca6b/attachment.htm>


More information about the gerrit-log mailing list