This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21378 ) Change subject: frame_relay: Fix error path on ioctl() failure ...................................................................... frame_relay: Fix error path on ioctl() failure We don't want to pass -EINVAL as file descriptor into the bind() call. Closes: CID#215529 Change-Id: Ic4d411c0ade6867c4fe2c01eb3368e6420158724 --- M src/gb/gprs_ns2_fr.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/gb/gprs_ns2_fr.c b/src/gb/gprs_ns2_fr.c index 80e3366..3315273 100644 --- a/src/gb/gprs_ns2_fr.c +++ b/src/gb/gprs_ns2_fr.c @@ -319,7 +319,7 @@ "cannot set this socket unblocking: %s\n", strerror(errno)); close(fd); - fd = -EINVAL; + return -EINVAL; } rc = bind(fd, (struct sockaddr *)&addr, sizeof(addr)); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21378 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic4d411c0ade6867c4fe2c01eb3368e6420158724 Gerrit-Change-Number: 21378 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201130/9380b8c3/attachment.htm>